linux-kernel - Re: [PATCH v12 0/3] Add QCOM SNPS PHY overriding params support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2022 21:44:17 +0530
From:   Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Vinod Koul <vkoul@...nel.org>,
        Wesley Cheng <quic_wcheng@...cinc.com>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Doug Anderson <dianders@...omium.org>
CC:     <devicetree@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>, <quic_pkondeti@...cinc.com>,
        <quic_ppratap@...cinc.com>, <quic_vpulyala@...cinc.com>
Subject: Re: [PATCH v12 0/3] Add QCOM SNPS PHY overriding params support



On 9/6/2022 9:42 PM, Krishna Kurapati wrote:
> Added support for overriding tuning parameters in QCOM SNPS PHY
> from device tree. This parameter tuning is required to tune the
> hs signal on dp/dm lines for electrical compliance to be successful.
> 
> Changes in v12:
> Fixed nitpicks in driver code.
> 
> Changes in v11:
> Made changes to logs added in phy driver.
> Fixed nitpicks in code.
> 
> Changes in v10:
> Fixed patch headers.
> 
> changes in v9:
> Fixed nitpick in driver code.
> 
> changes in v8:
> Fixed nitpick in driver code.
> 
> changes in v7:
> Fixed nitpick in driver code and dtsi file.
> 
> changes in v6:
> Fixed errors in dt-bindings.
> Fixed nitpick in driver code.
> 
> changes in v5:
> Fixed nitpicks in code.
> Added minimum and maximum for each parameter added in dt-bindings.
> Added proper suffixes to each parameter as per dtschema.
> 
> changes in v4:
> Fixed nitpicks in code.
> Initial compliance test results showed overshoot in the middle of eye
> diagram. The current dt values were put in place to correct it and fix
> overshoot issue.
> 
> changes in v3:
> Added support for phy tuning parameters to be represented in bps and
> corresponding register values to be written are obtained by traversing
> through data map declared in the driver.
> 
> changes in v2:
> Reading the individual fields in each overriding register from
> device tree.
> 
> Krishna Kurapati (2):
>    phy: qcom-snps: Add support for overriding phy tuning parameters
>    arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device
> 
> Sandeep Maheswaram (1):
>    dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params
>      bindings
> 
>   .../bindings/phy/qcom,usb-snps-femto-v2.yaml       |  88 +++++++
>   arch/arm64/boot/dts/qcom/sc7280-idp.dtsi           |   6 +
>   drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c      | 252 ++++++++++++++++++++-
>   3 files changed, 344 insertions(+), 2 deletions(-)
> 
Hi All,

  Please ignore this series. Re-sent v12 instead of v13.
Sorry for the inconvenience.

Regards,
Krishna,