linux-kernel - Re: [PATCH v2] rv/reactor: add __init/__exit annotations to module init/exit funcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a1cb21c-61f4-8ae6-8689-126ed85891ee@kernel.org>
Date:   Tue, 6 Sep 2022 19:34:03 +0200
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     Xiu Jianfeng <xiujianfeng@...wei.com>, rostedt@...dmis.org,
        mingo@...hat.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rv/reactor: add __init/__exit annotations to module
 init/exit funcs

On 9/6/22 16:12, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Fixes: 135b881ea885 ("rv/reactor: Add the printk reactor")
> Fixes: e88043c0ac16 ("rv/reactor: Add the panic reactor")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>

Acked-by: Daniel Bristot de Oliveira <bristot@...nel.org>

Thanks!
-- Daniel
> ---
>  kernel/trace/rv/reactor_panic.c  | 4 ++--
>  kernel/trace/rv/reactor_printk.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_panic.c
> index b698d05dd069..d65f6c25a87c 100644
> --- a/kernel/trace/rv/reactor_panic.c
> +++ b/kernel/trace/rv/reactor_panic.c
> @@ -24,13 +24,13 @@ static struct rv_reactor rv_panic = {
>  	.react = rv_panic_reaction
>  };
>  
> -static int register_react_panic(void)
> +static int __init register_react_panic(void)
>  {
>  	rv_register_reactor(&rv_panic);
>  	return 0;
>  }
>  
> -static void unregister_react_panic(void)
> +static void __exit unregister_react_panic(void)
>  {
>  	rv_unregister_reactor(&rv_panic);
>  }
> diff --git a/kernel/trace/rv/reactor_printk.c b/kernel/trace/rv/reactor_printk.c
> index 31899f953af4..4b6b7106a477 100644
> --- a/kernel/trace/rv/reactor_printk.c
> +++ b/kernel/trace/rv/reactor_printk.c
> @@ -23,13 +23,13 @@ static struct rv_reactor rv_printk = {
>  	.react = rv_printk_reaction
>  };
>  
> -static int register_react_printk(void)
> +static int __init register_react_printk(void)
>  {
>  	rv_register_reactor(&rv_printk);
>  	return 0;
>  }
>  
> -static void unregister_react_printk(void)
> +static void __exit unregister_react_printk(void)
>  {
>  	rv_unregister_reactor(&rv_printk);
>  }