linux-kernel - Re: [PATCH] of: irq: Report individual failures in of_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLhXE9E5UkGy+=t5Eas1KfTxmjm=mQcVVQ0MdAs7eYAtw@mail.gmail.com>
Date:   Tue, 6 Sep 2022 12:45:15 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Alexander A Sverdlin <alexander.sverdlin@...ia.com>
Cc:     devicetree@...r.kernel.org, Frank Rowand <frowand.list@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] of: irq: Report individual failures in of_irq_init()

On Tue, Sep 6, 2022 at 4:59 AM Alexander A Sverdlin
<alexander.sverdlin@...ia.com> wrote:
>
> From: Alexander Sverdlin <alexander.sverdlin@...ia.com>
>
> Rewrite pr_debug() as pr_err() to faciliate debugging.
>
> This change was inspired by a long lasting debugging of the
> octeon_irq_init_ciu() which fails completely silently and leaves the
> interrupt controller half-way configured which in turn had very non-obvious
> effects.

With this, if a node skipped completely won't be obvious. Please keep
the debug line and just add the error print.

>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>
> ---
>  drivers/of/irq.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index d22f605..45e4392 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -586,12 +586,12 @@ void __init of_irq_init(const struct of_device_id *matches)
>
>                         of_node_set_flag(desc->dev, OF_POPULATED);
>
> -                       pr_debug("of_irq_init: init %pOF (%p), parent %p\n",
> -                                desc->dev,
> -                                desc->dev, desc->interrupt_parent);
>                         ret = desc->irq_init_cb(desc->dev,
>                                                 desc->interrupt_parent);
>                         if (ret) {
> +                               pr_err("%s: Failed to init %pOF (%p), parent %p\n",
> +                                      __func__, desc->dev, desc->dev,
> +                                      desc->interrupt_parent);
>                                 of_node_clear_flag(desc->dev, OF_POPULATED);
>                                 kfree(desc);
>                                 continue;
> --
> 2.10.2
>