linux-kernel - Re: [PATCH] mfd: stmpe: switch to using gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxeOsttmiKZJL3Nz@google.com>
Date:   Tue, 6 Sep 2022 11:17:22 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Francesco Dolcini <francesco.dolcini@...adex.com>,
        Lee Jones <lee@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: stmpe: switch to using gpiod API

On Tue, Sep 06, 2022 at 01:29:21PM +0200, Linus Walleij wrote:
> On Tue, Sep 6, 2022 at 12:11 PM Francesco Dolcini
> <francesco.dolcini@...adex.com> wrote:
> > On Mon, Sep 05, 2022 at 10:01:47PM -0700, Dmitry Torokhov wrote:
> > > This patch switches the driver away from legacy gpio/of_gpio API to
> > > gpiod API, and removes use of of_get_named_gpio_flags() which I want to
> > > make private to gpiolib.
> > >
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > > ---
> > >  drivers/mfd/stmpe.c | 36 +++++++++++++-----------------------
> > >  1 file changed, 13 insertions(+), 23 deletions(-)
> > >
> > > diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> > > index 987e251d90ae..0c4f74197d3e 100644
> > > --- a/drivers/mfd/stmpe.c
> > > +++ b/drivers/mfd/stmpe.c
> > > @@ -8,14 +8,13 @@
> > >   */
> > >
> >
> > <snip>
> >
> > > -     pdata->irq_gpio = of_get_named_gpio_flags(np, "irq-gpio", 0,
> > <snip>
> > > +     irq_gpio = devm_gpiod_get_optional(ci->dev, "irq", GPIOD_ASIS);
> > isn't this changing from irq-gpio to irq-gpios property name?
> 
> The gpiolib core will automatically append and test the strings
> *-gpios and *-gpio (in that order)
> 
> > in the DTS files we do have something like that:
> >
> >  irq-gpio = <&gpio TEGRA_GPIO(V, 0) IRQ_TYPE_LEVEL_LOW>;
> 
> This seems to be an orthogonal bug.
> 
> That flag in the last cell is invalid for a GPIO, the DT schema should
> scream at you if you have one. GPIO flags are
> GPIO_ACTIVE_LOW, GPIO_OPEN_DRAIN etc. That looks more
> like an IRQ, and then the property should be irqs = <...>.

Francesco is right though in the sense that we need to update DTS
together with the patch, or we will break the driver... The original
code relied on the fact that flags returned by of_get_named_gpio_flags()
could contain anything, not necessarily valid GPIO flags.

Thanks.

-- 
Dmitry