linux-kernel - Re: [PATCH v11] dt-bindings: misc: fastrpc convert bindings to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxecLFC9HTye4FPP@linaro.org>
Date:   Tue, 6 Sep 2022 22:14:52 +0300
From:   Abel Vesa <abel.vesa@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Amol Maheshwari <amahesh@....qualcomm.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-remoteproc@...r.kernel.org, David Heidelberg <david@...t.cz>
Subject: Re: [PATCH v11] dt-bindings: misc: fastrpc convert bindings to yaml

On 22-09-06 18:12:51, Krzysztof Kozlowski wrote:
> On 06/09/2022 17:01, Abel Vesa wrote:
> > Convert Qualcomm FastRPC bindings to yaml format, so that we could validate
> > dt-entries correctly and any future additions can go into yaml format.
> > 
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> > +
> > +patternProperties:
> > +  "(compute-)?cb@[0-9]*$":
> > +    type: object
> > +
> > +    description: >
> > +      Each subnode of the Fastrpc represents compute context banks available on the dsp.
> > +
> > +    properties:
> > +      compatible:
> > +        const: qcom,fastrpc-compute-cb
> > +
> > +      reg:
> > +        maxItems: 1
> > +
> > +      qcom,nsession:
> > +        $ref: /schemas/types.yaml#/definitions/uint32
> > +        default: 1
> > +        description: >
> > +          A value indicating how many sessions can share this context bank.
> > +
> > +    required:
> > +      - compatible
> > +      - reg
> 
> I think this was pointed previously by Rob in v4 - you need here
> additionalProperties: false (on that level of indentation).

Ugh, I thought if the check doesn't complain, it is not necessary to add
it as false.

Will resend.

> 
> > +
> > +required:
> > +  - compatible
> > +  - label
> > +  - "#address-cells"
> > +  - "#size-cells"
> > +
> 
> 
> Best regards,
> Krzysztof