linux-kernel - Re: [EXT] build failure of next-20220906 due to 8bfc149ba24c ("scsi: qla2xxx: Enhance driver tracing with separate tunable and more")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVatmMsYk+tgJDASx2uoskLzY=b4m7SNo+3R6SXT=0vEnu+vA@mail.gmail.com>
Date:   Tue, 6 Sep 2022 21:57:10 +0100
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Arun Easi <aeasi@...vell.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Nilesh Javali <njavali@...vell.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        linux-scsi@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-next <linux-next@...r.kernel.org>
Subject: Re: [EXT] build failure of next-20220906 due to 8bfc149ba24c ("scsi:
 qla2xxx: Enhance driver tracing with separate tunable and more")

On Tue, Sep 6, 2022 at 5:05 PM Arun Easi <aeasi@...vell.com> wrote:
>
> Hi Sudip,
>
> On Tue, 6 Sep 2022, 7:32am, Sudip Mukherjee (Codethink) wrote:
>
> > External Email
> >
> > ----------------------------------------------------------------------
> > Hi All,
> >
> > The builds of loongarch loongson3_defconfig have failed to build
> > next-20220906 with the error:
> >
> > drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_init':
> > drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? [-Werror=implicit-function-declaration]
> >  2854 |         qla_trc_array = trace_array_get_by_name("qla2xxx");
> >       |                         ^~~~~~~~~~~~~~~~~~~~~~~
> >       |                         trace_array_set_clr_event
> >
> > drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_uninit':
> > drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function 'trace_array_put' [-Werror=implicit-function-declaration]
> >  2869 |         trace_array_put(qla_trc_array);
> >       |         ^~~~~~~~~~~~~~~
> >
> >
> > git bisect pointed to 8bfc149ba24c ("scsi: qla2xxx: Enhance driver tracing with separate tunable and more").
> >
> > I will be happy to test any patch or provide any extra log if needed.
> >
> >
>
> This looks like is happening due to CONFIG_TRACING not being enabled (same
> as what kernel test bot reported). Could you try out the fix attached?

Thanks, that fixed the build for me. The patch did not apply directly
on next-20220906, so I had to modify it a little bit.

Tested-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>

-- 
Regards
Sudip