linux-kernel - Re: [EXT] build failure of next-20220906 due to 8bfc149ba24c ("scsi: qla2xxx: Enhance driver tracing with separate tunable and more")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9f5eb5e-3830-d19b-dcb0-05f7a36fcb2d@marvell.com>
Date:   Tue, 6 Sep 2022 14:26:31 -0700
From:   Arun Easi <aeasi@...vell.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Nilesh Javali <njavali@...vell.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        <GR-QLogic-Storage-Upstream@...vell.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        <linux-scsi@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-next <linux-next@...r.kernel.org>
Subject: Re: [EXT] build failure of next-20220906 due to 8bfc149ba24c ("scsi:
 qla2xxx: Enhance driver tracing with separate tunable and more")

On Tue, 6 Sep 2022, 2:03pm, Steven Rostedt wrote:

> On Tue, 6 Sep 2022 21:57:10 +0100
> Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote:
> 
> > Thanks, that fixed the build for me. The patch did not apply directly
> > on next-20220906, so I had to modify it a little bit.
> > 
> > Tested-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> 
> Well, the change needs to go into include/linux/trace.h though.
> 

Steve, I was thinking both the fixes stay at least for a short 
term the one in qla2xxx to avoid tree dependencies.

Since, the qla_def.h change goes as:

+#ifndef CONFIG_TRACING
+#ifndef trace_array_get_by_name

..it should co-exist when the "#define trace_array_get_by_name" gets 
merged in include/linux/trace.h. BTW, I will send out the changes to 
trace.h today.

Other alternatives/suggestions welcome.

Regards,
-Arun