linux-kernel - Re: [PATCH linux-next] PCI: iproc: Remove the unneeded result variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cbe247d-f9a3-4770-1ca7-5ba5097451ba@broadcom.com>
Date:   Tue, 6 Sep 2022 14:27:46 -0700
From:   Scott Branden <scott.branden@...adcom.com>
To:     Bjorn Helgaas <helgaas@...nel.org>, cgel.zte@...il.com
Cc:     lpieralisi@...nel.org, robh@...nel.org, kw@...ux.com,
        bhelgaas@...gle.com, rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, linux-pci@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] PCI: iproc: Remove the unneeded result
 variable



On 2022-09-06 14:25, Bjorn Helgaas wrote:
> On Tue, Sep 06, 2022 at 07:16:36AM +0000, cgel.zte@...il.com wrote:
>> From: ye xingchen <ye.xingchen@....com.cn>
>>
>> Return the value iproc_pcie_setup_ib() directly instead of storing it in
>> another redundant variable.
>>
>> Reported-by: Zeal Robot <zealci@....com.cn>
>> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> 
> This patch itself is fine,
Does the patch serve any real use though?

  but was posted by cgel.zte@...il.com, not by
> "ye xingchen <ye.xingchen@....com.cn>", so it needs another signoff
> and full name so the chain is complete.  For more details see:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.18#n363
> 
> Bjorn

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)