linux-kernel - Re: [PATCH 1/2] PCI: histb: switch to using gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yxe+gPl5qeqJuC4Z@google.com>
Date:   Tue, 6 Sep 2022 14:41:20 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Pali Rohár <pali@...nel.org>
Cc:     Shawn Guo <shawn.guo@...aro.org>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] PCI: histb: switch to using gpiod API

On Tue, Sep 06, 2022 at 11:08:11PM +0200, Pali Rohár wrote:
> On Tuesday 06 September 2022 13:43:00 Dmitry Torokhov wrote:
> > +	ret = gpiod_set_consumer_name(hipcie->reset_gpio,
> > +				      "PCIe device power control");
> 
> Just unrelated thing, I know it was there before, but I saw it just now
> and have to comment it: This is absolute nonsense name. "reset-gpios"
> device tree property specifies PERST# signal pin (PciE ReSeT) as defined
> in PCIe CEM (Card ElectroMagnetic) specification and it has absolute
> nothing with PCIe power control.
> 
> My suggestion for maintainers would be to remove this critic name at
> all as it would just mislead other people reading that code.

I can respin the patch is you suggest a more sensible label...

> 
> > +	if (ret) {
> > +		dev_err(dev, "unable to set reset gpio name: %d\n", ret);
> > +		return ret;
> >  	}

Thanks.

-- 
Dmitry