linux-kernel - Re: [PATCH v8] mm/hmm/test: use char dev with struct device to get device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxfUGRA9q13V3+ja@ziepe.ca>
Date:   Tue, 6 Sep 2022 20:13:29 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     mpenttil@...hat.com, Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        apopple@...dia.com, jhubbard@...dia.com, rcampbell@...dia.com,
        vbabka@...e.cz
Subject: Re: [PATCH v8] mm/hmm/test: use char dev with struct device to get
 device node

On Fri, Aug 26, 2022 at 08:06:31AM +0300, mpenttil@...hat.com wrote:
> From: Mika Penttilä <mpenttil@...hat.com>
> 
> HMM selftests use an in-kernel pseudo device to emulate device
> memory. The pseudo device registers a major device range for two or
> four pseudo device instances. User space has a script that
> reads /proc/devices in order to find the assigned major number,
> and sends that to mknod(1), once for each node.
> 
> Change this to properly use cdev and struct device APIs.
> 
> Delete the /proc/devices parsing from the user-space test script, now
> that it is unnecessary.
> 
> Also, deleted an unused field in struct dmirror_device: devmem.
> 
> Signed-off-by: Mika Penttilä <mpenttil@...hat.com>
> Reviewed-by: John Hubbard <jhubbard@...dia.com>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>
> Cc: Alistair Popple <apopple@...dia.com>
> Cc: Ralph Campbell <rcampbell@...dia.com>
> Cc: Vlastimil Babka <vbabka@...e.cz>

Andrew, this looks OK, can you pick it up?

Thanks,
Jason