linux-kernel - Re: [PATCH v2] mm: hugetlb: eliminate memory-less nodes handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2022 14:47:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     Muchun Song <songmuchun@...edance.com>, gregkh@...uxfoundation.org,
        rafael@...nel.org, mike.kravetz@...cle.com,
        akpm@...ux-foundation.org, osalvador@...e.de, david@...hat.com,
        ying.huang@...el.com, aneesh.kumar@...ux.ibm.com,
        rientjes@...gle.com
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, muchun.song@...ux.dev
Subject: Re: [PATCH v2] mm: hugetlb: eliminate memory-less nodes handling

Hi Muchun,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20220901]
[cannot apply to akpm-mm/mm-everything driver-core/driver-core-testing linus/master v6.0-rc4 v6.0-rc3 v6.0-rc2 v6.0-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Muchun-Song/mm-hugetlb-eliminate-memory-less-nodes-handling/20220906-114538
base:    e47eb90a0a9ae20b82635b9b99a8d0979b757ad8
config: um-i386_defconfig
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/ec1575c86ce4904a7134d2fef8e231ecd50ffc75
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Muchun-Song/mm-hugetlb-eliminate-memory-less-nodes-handling/20220906-114538
        git checkout ec1575c86ce4904a7134d2fef8e231ecd50ffc75
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash fs/proc/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from fs/proc/array.c:74:
>> include/linux/hugetlb.h:1150:49: warning: 'struct node' declared inside parameter list will not be visible outside of this definition or declaration
    1150 | static inline void hugetlb_register_node(struct node *node)
         |                                                 ^~~~
   include/linux/hugetlb.h:1154:51: warning: 'struct node' declared inside parameter list will not be visible outside of this definition or declaration
    1154 | static inline void hugetlb_unregister_node(struct node *node)
         |                                                   ^~~~
--
   In file included from fs/proc/meminfo.c:6:
>> include/linux/hugetlb.h:1150:49: warning: 'struct node' declared inside parameter list will not be visible outside of this definition or declaration
    1150 | static inline void hugetlb_register_node(struct node *node)
         |                                                 ^~~~
   include/linux/hugetlb.h:1154:51: warning: 'struct node' declared inside parameter list will not be visible outside of this definition or declaration
    1154 | static inline void hugetlb_unregister_node(struct node *node)
         |                                                   ^~~~
   fs/proc/meminfo.c:22:28: warning: no previous prototype for 'arch_report_meminfo' [-Wmissing-prototypes]
      22 | void __attribute__((weak)) arch_report_meminfo(struct seq_file *m)
         |                            ^~~~~~~~~~~~~~~~~~~


vim +1150 include/linux/hugetlb.h

  1149	
> 1150	static inline void hugetlb_register_node(struct node *node)
  1151	{
  1152	}
  1153	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (42137 bytes)