linux-kernel - Re: [PATCH v7 1/2] dt-bindings: misc: fastrpc convert bindings to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxcIyRadKQN+BmRe@linaro.org>
Date:   Tue, 6 Sep 2022 11:46:01 +0300
From:   Abel Vesa <abel.vesa@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Amol Maheshwari <amahesh@....qualcomm.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        David Heidelberg <david@...t.cz>
Subject: Re: [PATCH v7 1/2] dt-bindings: misc: fastrpc convert bindings to
 yaml

On 22-09-06 10:36:14, Krzysztof Kozlowski wrote:
> On 06/09/2022 10:29, Abel Vesa wrote:
> > On 22-09-06 08:45:22, Krzysztof Kozlowski wrote:
> >> On 05/09/2022 16:45, Abel Vesa wrote:
> >>> Convert Qualcomm FastRPC bindings to yaml format, so that we could validate
> >>> dt-entries correctly and any future additions can go into yaml format.
> >>>
> >>> Use compute-cb@ subnodes instead of just cb@.
> >>>
> >>> Also add qcom,non-secure-domain, qcom,glink-channels and
> >>> qcom,smd-channels missing properties to make sure dtbs_check doesn't
> >>> fail right off the bat.
> >>
> >> qcom,non-secure-domain is in original binding, so I don't understand why
> >> it is being "added".
> >>
> > 
> > Yeah, my bad, I should've added this line to the changes since v4.
> > 
> >>>
> >>> Co-developed-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> >>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> >>> Co-developed-by: David Heidelberg <david@...t.cz>
> >>> Signed-off-by: David Heidelberg <david@...t.cz>
> >>> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> >>> ---
> >>>
> >>> Changes since v6:
> >>>  * renamed the parent node name in the example from smd-edge to glink-edge
> >>>
> >>>  .../devicetree/bindings/misc/qcom,fastrpc.txt |  88 -------------
> >>>  .../bindings/misc/qcom,fastrpc.yaml           | 118 ++++++++++++++++++
> >>
> >> As you can see in Rob's bot report - the patchset introduces errors and
> >> is not bisectable.
> > 
> > Please note that Rob's bot report is for v6.
> 
> I see report as a reply to this patch, so for v7. Why do you think it is v6?

Oh, didn't see Rob's bot reply to v7 before.

> 
> > 
> > v7 fixes the errors reported, by using glink-edge instead of smd-edge.
> > 
> > Looking at all QCOM SoCs that have fastrpc node in devicetree, they all
> > seem to be using glink-edge.
> 
> I was not talking about these errors (they were separate issue). I am
> talking about wrong path error.
> 

Yes, got it now. Will resend.

> > 
> >>
> >> You also need to fix qcom,glink-edge.yaml
> >>
> > 
> > I don't see why, with the changes I made in v7, there are no errors
> > anymore.
> 
> There are, but not from tooling. The error is wrong path. It should be
> converted to proper schema $ref.

Sure. Will do.

Thanks!

> 
> Best regards,
> Krzysztof