linux-kernel - Re: [PATCH v2 2/6] arm64: dts: imx8mq-librem5: add RGB pwm notification leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220906084531.GA29911@duo.ucw.cz>
Date:   Tue, 6 Sep 2022 10:45:31 +0200
From:   Pavel Machek <pavel@....cz>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     festevam@...il.com, shawnguo@...nel.org,
        devicetree@...r.kernel.org, kernel@...gutronix.de, kernel@...i.sm,
        krzk@...nel.org, linux-arm-kernel@...ts.infradead.org,
        linux-imx@....com, linux-kernel@...r.kernel.org,
        phone-devel@...r.kernel.org, robh@...nel.org,
        Guido Günther <agx@...xcpu.org>
Subject: Re: [PATCH v2 2/6] arm64: dts: imx8mq-librem5: add RGB pwm
 notification leds

Hi!

> From: Guido Günther <agx@...xcpu.org>
> 
> Describe the RGB notification leds on the Librem 5 phone.
> Use the common defines so we're sure to adhere to the common patterns,
> use predefined led colors and functions so we're being warned in case
> of deprecations.

I'd like LED lists to be cc-ed on patches like this, so that we can
keep userland API consistent.

In particular, RGB LED is very common feature on the phones, and it
would be good to have it consistent accross them. Can you take a look
at Documentation/leds/well-known-leds.txt, decide if your current API
is suitable, and update the file so that we get the consistency?

Thanks,
								Pavel

> +	led-controller {
> +		compatible = "pwm-leds";
> +
> +		led-0 {
> +			function = LED_FUNCTION_STATUS;
> +			color = <LED_COLOR_ID_BLUE>;
> +			max-brightness = <248>;
> +			pwms = <&pwm2 0 50000 0>;
> +		};
> +
> +		led-1 {
> +			function = LED_FUNCTION_STATUS;
> +			color = <LED_COLOR_ID_GREEN>;
> +			max-brightness = <248>;
> +			pwms = <&pwm4 0 50000 0>;
> +		};
> +
> +		led-2 {
> +			function = LED_FUNCTION_STATUS;
> +			color = <LED_COLOR_ID_RED>;
> +			max-brightness = <248>;
> +			pwms = <&pwm3 0 50000 0>;
> +		};
> +	};
> +
>  	reg_aud_1v8: regulator-audio-1v8 {
>  		compatible = "regulator-fixed";
>  		pinctrl-names = "default";
> -- 
> 2.30.2

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)