linux-kernel - RE: [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM5PR12MB1628DCF5CBEF7FA49EDE7DE9AD7E9@DM5PR12MB1628.namprd12.prod.outlook.com>
Date:   Tue, 6 Sep 2022 08:47:50 +0000
From:   Sandipan Patra <spatra@...dia.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Bibek Basu <bbasu@...dia.com>,
        Krishna Yarlagadda <kyarlagadda@...dia.com>
Subject: RE: [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234

Hi Krzysztof,

 > > +             pwm2: pwm@...0000 {
> > +                     compatible = "nvidia,tegra194-pwm",
> > +                                  "nvidia,tegra186-pwm";
> 
> This does not match bindings. Either DTS or bindings need to be fixed.

Thanks for reviewing the patches.

Tegra234 uses same compatible as Tegra194.
And also we can clear "nvidia,tegra186-pwm" from the Tegra234 pwm compatible list.
I will update binding doc and push new patch.


Thanks & Regards,
Sandipan



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Tuesday, August 30, 2022 3:20 PM
> To: Sandipan Patra <spatra@...dia.com>; thierry.reding@...il.com;
> Jonathan Hunter <jonathanh@...dia.com>; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; devicetree@...r.kernel.org; linux-
> tegra@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Bibek Basu <bbasu@...dia.com>; Krishna Yarlagadda
> <kyarlagadda@...dia.com>
> Subject: Re: [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234
> 
> External email: Use caution opening links or attachments
> 
> 
> On 29/08/2022 14:44, Sandipan Patra wrote:
> > Tegra234 has eight single-channel PWM controllers, one of them in the
> > AON block.
> >
> > Signed-off-by: Sandipan Patra <spatra@...dia.com>
> > ---
> >  arch/arm64/boot/dts/nvidia/tegra234.dtsi | 84
> > ++++++++++++++++++++++++
> >  1 file changed, 84 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > index 81a0f599685f..c2dc651f0842 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > @@ -840,6 +840,90 @@
> >                       #pwm-cells = <2>;
> >               };
> >
> > +             pwm2: pwm@...0000 {
> > +                     compatible = "nvidia,tegra194-pwm",
> > +                                  "nvidia,tegra186-pwm";
> 
> This does not match bindings. Either DTS or bindings need to be fixed.
> 
> Best regards,
> Krzysztof