linux-kernel - Re: [PATCH] mfd: stmpe: switch to using gpiod API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220906101126.GA8061@francesco-nb.int.toradex.com>
Date:   Tue, 6 Sep 2022 12:11:26 +0200
From:   Francesco Dolcini <francesco.dolcini@...adex.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Lee Jones <lee@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: stmpe: switch to using gpiod API

On Mon, Sep 05, 2022 at 10:01:47PM -0700, Dmitry Torokhov wrote:
> This patch switches the driver away from legacy gpio/of_gpio API to
> gpiod API, and removes use of of_get_named_gpio_flags() which I want to
> make private to gpiolib.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>  drivers/mfd/stmpe.c | 36 +++++++++++++-----------------------
>  1 file changed, 13 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index 987e251d90ae..0c4f74197d3e 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -8,14 +8,13 @@
>   */
>  

<snip>

> -	pdata->irq_gpio = of_get_named_gpio_flags(np, "irq-gpio", 0,
<snip>
> +	irq_gpio = devm_gpiod_get_optional(ci->dev, "irq", GPIOD_ASIS);
isn't this changing from irq-gpio to irq-gpios property name?

in the DTS files we do have something like that:

 irq-gpio = <&gpio TEGRA_GPIO(V, 0) IRQ_TYPE_LEVEL_LOW>;


Francesco