linux-kernel - Re: [PATCH v9 6/6] thunderbolt: Add support for ASMedia image format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yxce0WshoIgS7zBz@black.fi.intel.com>
Date:   Tue, 6 Sep 2022 13:20:01 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Szuying Chen <chensiying21@...il.com>
Cc:     YehezkelShB@...il.com, gregkh@...uxfoundation.org,
        mario.limonciello@....com, andreas.noever@...il.com,
        michael.jamet@...el.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, Yd_Tseng@...edia.com.tw,
        Chloe_Chen@...edia.com.tw, Richard_Hsu@...edia.com.tw
Subject: Re: [PATCH v9 6/6] thunderbolt: Add support for ASMedia image format

On Tue, Sep 06, 2022 at 06:11:28PM +0800, Szuying Chen wrote:
> From: Szuying Chen <Chloe_Chen@...edia.com.tw>
> 
> Hi,
> 
> >  
> > +static int asmedia_switch_nvm_version(struct tb_nvm *nvm) {
> > +	struct tb_switch *sw = tb_to_switch(nvm->dev);
> > +	u32 val;
> > +	int ret;
> > +
> > +	ret = tb_switch_nvm_read(sw, ASMEDIA_NVM_VERSION, &val, sizeof(val));
> > +	if (ret)
> > +		return ret;
> > +
> > +	nvm->major = (val << 16) & 0xff0000;
> > +	nvm->minor |= val & 0x00ff00;
> 
> 	nvm->major

Heh, that one was clearly a copy paste error ;-)

I will fix it up when applying. Thanks for checking.