linux-kernel - Re: [PATCH V8 4/6] soc: imx: add i.MX93 media blk ctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2022 10:09:17 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Peng Fan <peng.fan@....nxp.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, aisheng.dong@....com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH V8 4/6] soc: imx: add i.MX93 media blk ctrl driver

On Mon, Sep 05, 2022 at 02:47:16PM +0800, Peng Fan wrote:
[...]
> > > +struct imx93_blk_ctrl_data {
> > > +	const struct imx93_blk_ctrl_domain_data *domains;
> > > +	const struct imx93_blk_ctrl_domain_data *bus;
> > 
> > It looks confusing to claim 'bus' as an imx93_blk_ctrl_domain_data.  I
> > would suggest you have 'related' fields directly defined in
> > imx93_blk_ctrl_data.
> 
> This would implies a bit large change to this driver.
> 
> Should I use a new V1 for the patchset or continue V9 for next version?

I think v9 is fine.

Shawn