linux-kernel - Re: [RFC PATCH v2 1/2] misc: pci_endpoint_test: Aggregate params checking for xfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yxcn4CPN3BkC9xg7@kroah.com>
Date:   Tue, 6 Sep 2022 12:58:40 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Shunsuke Mie <mie@...l.co.jp>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Arnd Bergmann <arnd@...db.de>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 1/2] misc: pci_endpoint_test: Aggregate params
 checking for xfer

On Tue, Sep 06, 2022 at 07:15:54PM +0900, Shunsuke Mie wrote:
> Each transfer test functions have same parameter checking code. This patch
> unites those to an introduced function.
> 
> Signed-off-by: Shunsuke Mie <mie@...l.co.jp>
> ---
> Changes in v2:
> * New patch
> ---
> ---
>  drivers/misc/pci_endpoint_test.c | 35 ++++++++++++++++++++++++++------
>  1 file changed, 29 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 8f786a225dcf..3bd9f135cdac 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -332,6 +332,17 @@ static bool pci_endpoint_test_msi_irq(struct pci_endpoint_test *test,
>  	return false;
>  }
>  
> +static int pci_endpoint_test_validate_xfer_params(struct device *dev,
> +		struct pci_endpoint_test_xfer_param *param, size_t alignment)
> +{
> +	if (param->size > SIZE_MAX - alignment) {
> +		dev_err(dev, "Maximum transfer data size exceeded\n");
> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}
> +
>  static bool pci_endpoint_test_copy(struct pci_endpoint_test *test,
>  				   unsigned long arg)
>  {
> @@ -363,9 +374,13 @@ static bool pci_endpoint_test_copy(struct pci_endpoint_test *test,
>  		return false;
>  	}
>  
> +	err = pci_endpoint_test_validate_xfer_params(dev, &param, alignment);
> +	if (err) {
> +		dev_err(dev, "Invalid parameter\n");

Also, you just printed 2 errors for the same error.  Not needed.