linux-kernel - Re: [PATCH v2 char-misc-next] misc: microchip: pci1xxxx: fix dependency issues in building the pci1xxxx's aux bus driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yxcpc7ao10kytxbV@kroah.com>
Date:   Tue, 6 Sep 2022 13:05:23 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>
Cc:     linux-kernel@...r.kernel.org, kbuild-all@...ts.01.org,
        lkp@...el.com
Subject: Re: [PATCH v2 char-misc-next] misc: microchip: pci1xxxx: fix
 dependency issues in building the pci1xxxx's aux bus driver.

On Tue, Sep 06, 2022 at 04:06:58PM +0530, Kumaravel Thiagarajan wrote:
> build errors and warnings listed below and reported by kernel
> test robot <lkp@...el.com> on the char-misc-next branch are
> fixed in this add-on patch.
> 
> errors:
> ERROR: modpost: "auxiliary_device_init"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.ko] undefined!

These lines should now be wrapped, it's ok to have long lines that show
the error messages.

> ERROR: modpost: "__auxiliary_device_add"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.ko] undefined!
> ERROR: modpost: "auxiliary_driver_unregister"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.ko] undefined!
> ERROR: modpost: "__auxiliary_driver_register"
>  [drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.ko] undefined!
> ia64-linux-ld: drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.o:
>  in function `gp_aux_bus_probe.part.0':
> mchp_pci1xxxx_gp.c:(.text+0x342): undefined reference to
>  `auxiliary_device_init'
> ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x392):
>  undefined reference to `__auxiliary_device_add'
> ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x5c2):
>  undefined reference to `auxiliary_device_init'
> ia64-linux-ld: mchp_pci1xxxx_gp.c:(.text+0x612):
>  undefined reference to `__auxiliary_device_add'
> ia64-linux-ld: drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.o:
>  in function `pci1xxxx_gpio_driver_init':
>  mchp_pci1xxxx_gpio.c:(.init.text+0x42): undefined reference to
>  `__auxiliary_driver_register'
> 
> warnings:
> unmet direct dependencies detected for GPIOLIB_IRQCHIP when selected by
>  GP_PCI1XXXX

Same here.

> 
> Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver
>  for the PIO function in the multi-function endpoint of pci1xxxx device.")

That all needs to be on one line.

> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>
> ---
>  drivers/misc/mchp_pci1xxxx/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

And as you said, no v2 information :(

v3 please?

thanks,

greg k-h