[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5f4d77c3-ec58-659e-0b03-a799b3782a31@arm.com>
Date: Tue, 6 Sep 2022 12:42:32 +0100
From: Robin Murphy <robin.murphy@....com>
To: Jingyu Wang <jingyuwang_vip@....com>, alexander.deucher@....com,
christian.koenig@....com, Xinhui.Pan@....com, airlied@...ux.ie,
daniel@...ll.ch, evan.quan@....com, mario.limonciello@....com,
Felix.Kuehling@....com, andrey.grodzovsky@....com,
olomon.chiu@....com
Cc: dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_drv.c
On 2022-09-04 20:15, Jingyu Wang wrote:
[...]
> @@ -565,8 +566,8 @@ module_param_named(timeout_period, amdgpu_watchdog_timer.period, uint, 0644);
> */
> #ifdef CONFIG_DRM_AMDGPU_SI
>
> -#if defined(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE)
> -int amdgpu_si_support = 0;
> +#if IS_ENABLED(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE)
Hint: read the checkpatch warning again more closely, and consider what
IS_ENABLED() does and therefore why this is still not quite right.
Robin.
> +int amdgpu_si_support;
> MODULE_PARM_DESC(si_support, "SI support (1 = enabled, 0 = disabled (default))");
> #else
> int amdgpu_si_support = 1;
Powered by blists - more mailing lists