[<prev] [next>] [day] [month] [year] [list]
Message-ID: <bc21af63b3babeec577a4b059f6e686f24be9001.camel@mediatek.com>
Date: Tue, 6 Sep 2022 10:28:28 +0800
From: Nathan Lu <nathan.lu@...iatek.com>
To: CK Hu <ck.hu@...iatek.com>, Rob Herring <robh+dt@...nel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
Chun-Kuang Hu <chunkuang.hu@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
"David Airlie" <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Matthias Brugger <matthias.bgg@...il.com>
CC: "jason-jh . lin" <jason-jh.lin@...iatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Rex-BC Chen <rex-bc.chen@...iatek.com>,
Enric Balletbo i Serra <enric.balletbo@...labora.com>,
Moudy Ho <moudy.ho@...iatek.com>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
<linux-mediatek@...ts.infradead.org>,
<linux-stm32@...md-mailman.stormreply.com>,
<linux-arm-kernel@...ts.infradead.org>,
<srv_heupstream@...iatek.com>, <wsd_upstream@...iatek.com>,
<lancelot.wu@...iatek.com>
Subject: Re: [PATCH v1 1/4] dt-bindings: mediatek: modify VDOSYS0 device
tree Documentations for MT8188
Hi CK,
Thanks for your review, and appreciate for all comments and sugestions.
I'll seperate mmsys/mutex/display to different patch and remove all
unnecessary modify at next version
On Mon, 2022-08-22 at 13:36 +0800, CK Hu wrote:
> Hi, Nathan:
>
> On Mon, 2022-08-22 at 11:32 +0800, nathan.lu wrote:
> > From: Nathan Lu <nathan.lu@...iatek.com>
> >
> > modify VDOSYS0 device tree Documentations for MT8188.
> >
> > Signed-off-by: Nathan Lu <nathan.lu@...iatek.com>
> > ---
> > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 1
> > +
> > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 1
> > +
> > .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 1
> > +
> > .../devicetree/bindings/display/mediatek/mediatek,color.yaml | 1
> > +
> > .../devicetree/bindings/display/mediatek/mediatek,dither.yaml | 1
> > +
> > .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 3
> > ++-
> > .../devicetree/bindings/display/mediatek/mediatek,ovl.yaml | 1
> > +
> > .../bindings/display/mediatek/mediatek,postmask.yaml | 1
> > +
> > .../devicetree/bindings/display/mediatek/mediatek,rdma.yaml |
> > 2
>
> Separate the display part to another patch for the maintainer it
> belong
> to.
>
> > ++
> > .../devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1
> > +
> > 10 files changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > index 6ad023eec193..f26f61069181 100644
> > ---
> > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > @@ -30,6 +30,7 @@ properties:
> > - mediatek,mt8173-mmsys
> > - mediatek,mt8183-mmsys
> > - mediatek,mt8186-mmsys
> > + - mediatek,mt8188-mmsys
> > - mediatek,mt8192-mmsys
> > - mediatek,mt8195-mmsys
> > - mediatek,mt8365-mmsys
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > am
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > am
> > l
> > index d4d585485e7b..92741486c24d 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > am
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y
> > am
> > l
> > @@ -31,6 +31,7 @@ properties:
> > - items:
> > - enum:
> > - mediatek,mt8186-disp-aal
> > + - mediatek,mt8188-disp-aal
> > - mediatek,mt8192-disp-aal
> > - mediatek,mt8195-disp-aal
> > - const: mediatek,mt8183-disp-aal
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr
> > .y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr
> > .y
> > aml
> > index 63fb02014a56..fe444beff558 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr
> > .y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr
> > .y
> > aml
> > @@ -27,6 +27,7 @@ properties:
> > - const: mediatek,mt8192-disp-ccorr
> > - items:
> > - enum:
> > + - mediatek,mt8188-disp-ccorr
> > - mediatek,mt8195-disp-ccorr
> > - const: mediatek,mt8192-disp-ccorr
> > - items:
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,color
> > .y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,color
> > .y
> > aml
> > index d2f89ee7996f..62306c88f485 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,color
> > .y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,color
> > .y
> > aml
> > @@ -37,6 +37,7 @@ properties:
> > - enum:
> > - mediatek,mt8183-disp-color
> > - mediatek,mt8186-disp-color
> > + - mediatek,mt8188-disp-color
> > - mediatek,mt8192-disp-color
> > - mediatek,mt8195-disp-color
> > - const: mediatek,mt8173-disp-color
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe
> > r.
> > yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe
> > r.
> > yaml
> > index 8ad8187c02d1..5c7445c174e5 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe
> > r.
> > yaml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe
> > r.
> > yaml
> > @@ -27,6 +27,7 @@ properties:
> > - items:
> > - enum:
> > - mediatek,mt8186-disp-dither
> > + - mediatek,mt8188-disp-dither
> > - mediatek,mt8192-disp-dither
> > - mediatek,mt8195-disp-dither
> > - const: mediatek,mt8183-disp-dither
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .y
> > aml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .y
> > aml
> > index a89ea0ea7542..3d6e20f6eb05 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .y
> > aml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .y
> > aml
> > @@ -12,7 +12,7 @@ maintainers:
> >
> > description: |
> > Mediatek display gamma correction, namely GAMMA, provides a
> > nonlinear
> > - operation used to adjust luminance in display system.
> > + operation used to adjust luminance in?display system.
>
> It's not necessary to modify this.
>
> Regards,
> CK
>
> > GAMMA device node must be siblings to the central MMSYS_CONFIG
> > node.
> > For a description of the MMSYS_CONFIG binding, see
> > Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.ya
> > ml
> > @@ -28,6 +28,7 @@ properties:
> > - items:
> > - enum:
> > - mediatek,mt8186-disp-gamma
> > + - mediatek,mt8188-disp-gamma
> > - mediatek,mt8192-disp-gamma
> > - mediatek,mt8195-disp-gamma
> > - const: mediatek,mt8183-disp-gamma
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > am
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > am
> > l
> > index a2a27d0ca038..065e526f950e 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > am
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y
> > am
> > l
> > @@ -36,6 +36,7 @@ properties:
> > - const: mediatek,mt2701-disp-ovl
> > - items:
> > - enum:
> > + - mediatek,mt8188-disp-ovl
> > - mediatek,mt8195-disp-ovl
> > - const: mediatek,mt8183-disp-ovl
> > - items:
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,postm
> > as
> > k.yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,postm
> > as
> > k.yaml
> > index 654080bfbdfb..27de64495401 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,postm
> > as
> > k.yaml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,postm
> > as
> > k.yaml
> > @@ -26,6 +26,7 @@ properties:
> > - items:
> > - enum:
> > - mediatek,mt8186-disp-postmask
> > + - mediatek,mt8188-disp-postmask
> > - const: mediatek,mt8192-disp-postmask
> >
> > reg:
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.
> > ya
> > ml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.
> > ya
> > ml
> > index 0882ae86e6c4..d0e6c0dd4dfb 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.
> > ya
> > ml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.
> > ya
> > ml
> > @@ -30,6 +30,8 @@ properties:
> > - items:
> > - const: mediatek,mt8183-disp-rdma
> > - items:
> > + - enum:
> > + - mediatek,mt8188-disp-rdma
> > - const: mediatek,mt8195-disp-rdma
> > - items:
> > - enum:
> > diff --git
> > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yam
> > l
> > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yam
> > l
> > index 627dcc3e8b32..a5212a2a4dcc 100644
> > ---
> > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yam
> > l
> > @@ -30,6 +30,7 @@ properties:
> > - mediatek,mt8173-disp-mutex
> > - mediatek,mt8183-disp-mutex
> > - mediatek,mt8186-disp-mutex
> > + - mediatek,mt8188-disp-mutex
> > - mediatek,mt8192-disp-mutex
> > - mediatek,mt8195-disp-mutex
> >
>
>
Powered by blists - more mailing lists