linux-kernel - Re: [PATCH stable-5.15 1/3] usb: dwc3: fix PHY disable sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2022 14:16:24 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        Johan Hovold <johan+linaro@...nel.org>,
        Andrew Halaney <ahalaney@...hat.com>,
        Matthias Kaehlcke <mka@...omium.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Subject: Re: [PATCH stable-5.15 1/3] usb: dwc3: fix PHY disable sequence

On Tue, Sep 06, 2022 at 02:07:00PM +0200, Johan Hovold wrote:
> From: Johan Hovold <johan+linaro@...nel.org>
> 
> commit d2ac7bef95c9ead307801ccb6cb6dfbeb14247bf upstream.
> 
> Generic PHYs must be powered-off before they can be tore down.
> 
> Similarly, suspending legacy PHYs after having powered them off makes no
> sense.
> 
> Fix the dwc3_core_exit() (e.g. called during suspend) and open-coded
> dwc3_probe() error-path sequences that got this wrong.
> 
> Note that this makes dwc3_core_exit() match the dwc3_core_init() error
> path with respect to powering off the PHYs.
> 
> Fixes: 03c1fd622f72 ("usb: dwc3: core: add phy cleanup for probe error handling")
> Fixes: c499ff71ff2a ("usb: dwc3: core: re-factor init and exit paths")
> Cc: stable@...r.kernel.org      # 4.8
> Reviewed-by: Andrew Halaney <ahalaney@...hat.com>
> Reviewed-by: Matthias Kaehlcke <mka@...omium.org>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> Link: https://lore.kernel.org/r/20220804151001.23612-2-johan+linaro@kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> [ johan: adjust context to 5.15 ]
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>  drivers/usb/dwc3/core.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)

This one did not apply to 4.9.y, 4.14.y, or 4.19.y :(