linux-kernel - Re: [PATCH] linkstate: Add macros for link state up/down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yxc6o+6u2zlPxU3a@lunn.ch>
Date:   Tue, 6 Sep 2022 14:18:43 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Olliver Schinagl <oliver@...inagl.nl>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        Alexandru Tachici <alexandru.tachici@...log.com>,
        Hao Chen <chenhao288@...ilicon.com>,
        Olliver Schinagl <oliver+list@...inagl.nl>,
        "David S . Miller" <davem@...emloft.net>,
        Ido Schimmel <idosch@...dia.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH] linkstate: Add macros for link state up/down

On Tue, Sep 06, 2022 at 10:37:54AM +0200, Olliver Schinagl wrote:
> The phylink_link_state.state property can be up or down, via 1 and 0.
> 
> The other link state's (speed, duplex) are defined in ethtool.h so lets
> add defines for the link-state there as well so we can use macro's to
> define our up/down states.

Hi Olliver

The change itself is fine, but we don't add to the API without
users. Please make use of these two new values somewhere, to show they
are really useful.

    Andrew