linux-kernel - Re: usb: dwc3: disable USB core PHY management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yxc8lQ+ckvMJ8R9D@hovoldconsulting.com>
Date:   Tue, 6 Sep 2022 14:27:01 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        Johan Hovold <johan+linaro@...nel.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        stable <stable@...nel.org>
Subject: Re: usb: dwc3: disable USB core PHY management

On Tue, Sep 06, 2022 at 02:18:08PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 06, 2022 at 02:07:02PM +0200, Johan Hovold wrote:
> > From: Johan Hovold <johan+linaro@...nel.org>
> > 
> > commit 6000b8d900cd5f52fbcd0776d0cc396e88c8c2ea upstream.
> > 
> > The dwc3 driver manages its PHYs itself so the USB core PHY management
> > needs to be disabled.
> > 
> > Use the struct xhci_plat_priv hack added by commits 46034a999c07 ("usb:
> > host: xhci-plat: add platform data support") and f768e718911e ("usb:
> > host: xhci-plat: add priv quirk for skip PHY initialization") to
> > propagate the setting for now.
> > 
> > Fixes: 4e88d4c08301 ("usb: add a flag to skip PHY initialization to struct usb_hcd")
> > Fixes: 178a0bce05cb ("usb: core: hcd: integrate the PHY wrapper into the HCD core")
> > Tested-by: Matthias Kaehlcke <mka@...omium.org>
> > Cc: stable <stable@...nel.org>
> > Reviewed-by: Matthias Kaehlcke <mka@...omium.org>
> > Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> > Link: https://lore.kernel.org/r/20220825131836.19769-1-johan+linaro@kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > [ johan: adjust context to 5.15 ]
> > Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  drivers/usb/dwc3/host.c |   10 ++++++++++
> >  1 file changed, 10 insertions(+)
> 
> Breaks the build on 4.19.y :(

It's OK to not to backport this one.

Johan