lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Sep 2022 15:36:34 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Crt Mori <cmo@...exis.com> Cc: Jonathan Cameron <jic23@...nel.org>, linux-iio <linux-iio@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v3 1/3] iio: temperature: mlx90632 Add runtime powermanagement modes On Tue, Sep 6, 2022 at 1:52 PM Crt Mori <cmo@...exis.com> wrote: > On Tue, 6 Sept 2022 at 12:21, Andy Shevchenko <andy.shevchenko@...il.com> wrote: > > > > Very good and documented code, thanks! > > I believe you better to use DEFINE_.*_PM_OPS instead of legacy ones > > (due to pm_ptr() usage). > > Otherwise, with some nitpicks that wouldn't prevent a green light, > > Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com> > > > I checked DEFINE_.*_PM_OPS usage around drivers and you either have > SIMPLE (where you define suspend/resume) or you have RUNTIME (for > runtime suspend/resume), but never are those two together. So I am a > bit puzzled how to get this working. The one which suits here is called _DEFINE_DEV_PM_OPS(). But it's basically the same what you put here with the possible unused case. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists