lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Sep 2022 10:39:06 +0800 From: Nathan Lu <nathan.lu@...iatek.com> To: CK Hu <ck.hu@...iatek.com>, Rob Herring <robh+dt@...nel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>, Chun-Kuang Hu <chunkuang.hu@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, "David Airlie" <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Matthias Brugger <matthias.bgg@...il.com> CC: "jason-jh . lin" <jason-jh.lin@...iatek.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Rex-BC Chen <rex-bc.chen@...iatek.com>, Enric Balletbo i Serra <enric.balletbo@...labora.com>, Moudy Ho <moudy.ho@...iatek.com>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>, <linux-mediatek@...ts.infradead.org>, <linux-stm32@...md-mailman.stormreply.com>, <linux-arm-kernel@...ts.infradead.org>, <srv_heupstream@...iatek.com>, <wsd_upstream@...iatek.com>, <lancelot.wu@...iatek.com>, amy zhang <Amy.Zhang@...iatek.com> Subject: Re: [PATCH v1 4/4] drm/mediatek: add mediatek-drm of vdosys0 support for mt8188 Hi CK, Thanks for your review, and appreciate for all comments and sugestions. I'll remove io_start variable at next version. It will be upstream with vdosys1 patch later. On Mon, 2022-08-22 at 13:50 +0800, CK Hu wrote: > Hi, Nathan: > > On Mon, 2022-08-22 at 11:32 +0800, nathan.lu wrote: > > From: Nathan Lu <nathan.lu@...iatek.com> > > > > add driver data of mt8188 vdosys0 to mediatek-drm and the sub > > driver. > > > > Signed-off-by: amy zhang <Amy.Zhang@...iatek.com> > > Signed-off-by: Nathan Lu <nathan.lu@...iatek.com> > > --- > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 30 > > ++++++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > index d72263c8a621..260514006093 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > @@ -178,6 +178,18 @@ static const unsigned int mt8186_mtk_ddp_ext[] > > = > > { > > DDP_COMPONENT_DPI0, > > }; > > > > +static const unsigned int mt8188_mtk_ddp_main[] = { > > + DDP_COMPONENT_OVL0, > > + DDP_COMPONENT_RDMA0, > > + DDP_COMPONENT_COLOR0, > > + DDP_COMPONENT_CCORR, > > + DDP_COMPONENT_AAL0, > > + DDP_COMPONENT_GAMMA, > > + DDP_COMPONENT_POSTMASK0, > > + DDP_COMPONENT_DITHER0, > > + DDP_COMPONENT_DP_INTF0, > > +}; > > + > > static const unsigned int mt8192_mtk_ddp_main[] = { > > DDP_COMPONENT_OVL0, > > DDP_COMPONENT_OVL_2L0, > > @@ -323,6 +335,20 @@ static const struct mtk_mmsys_match_data > > mt8186_mmsys_match_data = { > > }, > > }; > > > > +static const struct mtk_mmsys_driver_data > > mt8188_vdosys0_driver_data > > = { > > + .io_start = 0x1c01d000, > > For only one mmsys, it's not necessary to set io_start. > > Regards, > CK > > > + .main_path = mt8188_mtk_ddp_main, > > + .main_len = ARRAY_SIZE(mt8188_mtk_ddp_main), > > + .mmsys_dev_num = 1, > > +}; > > + > > +static const struct mtk_mmsys_match_data mt8188_mmsys_match_data = > > { > > + .num_drv_data = 1, > > + .drv_data = { > > + &mt8188_vdosys0_driver_data, > > + }, > > +}; > > + > > static const struct mtk_mmsys_driver_data mt8192_mmsys_driver_data > > = > > { > > .main_path = mt8192_mtk_ddp_main, > > .main_len = ARRAY_SIZE(mt8192_mtk_ddp_main), > > @@ -376,6 +402,8 @@ static const struct of_device_id > > mtk_drm_of_ids[] > > = { > > .data = &mt8183_mmsys_match_data}, > > { .compatible = "mediatek,mt8186-mmsys", > > .data = &mt8186_mmsys_match_data}, > > + { .compatible = "mediatek,mt8188-mmsys", > > + .data = &mt8188_mmsys_match_data}, > > { .compatible = "mediatek,mt8192-mmsys", > > .data = &mt8192_mmsys_match_data}, > > { .compatible = "mediatek,mt8195-mmsys", > > @@ -734,6 +762,8 @@ static const struct of_device_id > > mtk_ddp_comp_dt_ids[] = { > > .data = (void *)MTK_DISP_MUTEX }, > > { .compatible = "mediatek,mt8186-disp-mutex", > > .data = (void *)MTK_DISP_MUTEX }, > > + { .compatible = "mediatek,mt8188-disp-mutex", > > + .data = (void *)MTK_DISP_MUTEX }, > > { .compatible = "mediatek,mt8192-disp-mutex", > > .data = (void *)MTK_DISP_MUTEX }, > > { .compatible = "mediatek,mt8195-disp-mutex", > >
Powered by blists - more mailing lists