linux-kernel - Re: [PATCH V2] perf dlfilter: dlfilter-show-cycles: Fix types for print format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2022 09:58:59 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] perf dlfilter: dlfilter-show-cycles: Fix types for
 print format

Em Mon, Sep 05, 2022 at 10:47:35AM +0300, Adrian Hunter escreveu:
> Avoid compiler warning about format %llu that expects long long unsigned
> int but argument has type __u64.
> 
> Fixes: c3afd6e50fce ("perf dlfilter: Add dlfilter-show-cycles")
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> ---
> 
> 
> Changes in V2:
> 
> 	Add fixes tag

Thanks, applied.

- Arnaldo

 
> 
>  tools/perf/dlfilters/dlfilter-show-cycles.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/dlfilters/dlfilter-show-cycles.c b/tools/perf/dlfilters/dlfilter-show-cycles.c
> index 9eccc97bff82..6d47298ebe9f 100644
> --- a/tools/perf/dlfilters/dlfilter-show-cycles.c
> +++ b/tools/perf/dlfilters/dlfilter-show-cycles.c
> @@ -98,9 +98,9 @@ int filter_event_early(void *data, const struct perf_dlfilter_sample *sample, vo
>  static void print_vals(__u64 cycles, __u64 delta)
>  {
>  	if (delta)
> -		printf("%10llu %10llu ", cycles, delta);
> +		printf("%10llu %10llu ", (unsigned long long)cycles, (unsigned long long)delta);
>  	else
> -		printf("%10llu %10s ", cycles, "");
> +		printf("%10llu %10s ", (unsigned long long)cycles, "");
>  }
>  
>  int filter_event(void *data, const struct perf_dlfilter_sample *sample, void *ctx)
> -- 
> 2.25.1

-- 

- Arnaldo