linux-kernel - Re: [PATCH v12 2/3] phy: qcom-snps: Add support for overriding phy tuning parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220906024552.lob5k4q3iyagyo5e@baldur>
Date:   Mon, 5 Sep 2022 21:45:52 -0500
From:   Bjorn Andersson <andersson@...nel.org>
To:     Krishna Kurapati <quic_kriskura@...cinc.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Vinod Koul <vkoul@...nel.org>,
        Wesley Cheng <quic_wcheng@...cinc.com>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Doug Anderson <dianders@...omium.org>,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-phy@...ts.infradead.org, quic_pkondeti@...cinc.com,
        quic_ppratap@...cinc.com, quic_vpulyala@...cinc.com
Subject: Re: [PATCH v12 2/3] phy: qcom-snps: Add support for overriding phy
 tuning parameters

On Sat, Sep 03, 2022 at 04:00:47PM +0530, Krishna Kurapati wrote:
[..]
> +static void qcom_snps_hsphy_read_override_param_seq(struct device *dev)
> +{
> +	struct device_node *node = dev->of_node;
> +	s32 val;
> +	int ret, i;
> +	struct qcom_snps_hsphy *hsphy;
> +	const struct override_param_map *cfg = of_device_get_match_data(dev);

Given that you don't have any .data specified for the other compatibles
(which is fine), cfg would be NULL here and below loop would attempt to
access NULL[0].prop_name and crash.

Please add a check for !cfg and just return here.

With that I think the series looks good.

Regards,
Bjorn