[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_Ms18MHqyQVZ7UMQUCGGinzWtb5SkLubjSceOgrfJn+Ag@mail.gmail.com>
Date: Wed, 7 Sep 2022 10:56:36 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Robin Murphy <robin.murphy@....com>
Cc: Jilin Yuan <yuanjilin@...rlc.com>, airlied@...ux.ie,
daniel@...ll.ch, isabbasso@...eup.net,
amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: fix repeated words in comments
On Wed, Sep 7, 2022 at 10:50 AM Robin Murphy <robin.murphy@....com> wrote:
>
> On 2022-09-07 12:26, Jilin Yuan wrote:
> > Delete the redundant word 'we'.
>
> FWIW, to me it's not redundant because while indeed it is not correct,
> it looks exactly like the kind of typo I might make of "if we", and
> parsing it as *that* does make sense. The sentence you end up with here
> can hardly be considered an improvement since it is still ungrammatical
> nonsense.
Yes, I believe this was supposed to say "if we" rather than "we we".
Alex
>
> Robin.
>
> > Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> > index 02cb3a12dd76..6d6cc4637d41 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
> > @@ -694,7 +694,7 @@ static int amdgpu_vce_cs_reloc(struct amdgpu_cs_parser *p, struct amdgpu_ib *ib,
> > * @allocated: allocated a new handle?
> > *
> > * Validates the handle and return the found session index or -EINVAL
> > - * we we don't have another free session index.
> > + * we don't have another free session index.
> > */
> > static int amdgpu_vce_validate_handle(struct amdgpu_cs_parser *p,
> > uint32_t handle, uint32_t *allocated)
Powered by blists - more mailing lists