linux-kernel - Re: [PATCH 4/15] cxl: Unify debug messages when calling devm_cxl_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220907162909.sum6u2kb3rma3oxb@offworld>
Date:   Wed, 7 Sep 2022 09:29:09 -0700
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Robert Richter <rrichter@....com>
Cc:     Alison Schofield <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Ira Weiny <ira.weiny@...el.com>,
        Ben Widawsky <bwidawsk@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        linux-cxl@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>
Subject: Re: [PATCH 4/15] cxl: Unify debug messages when calling
 devm_cxl_add_dport()

On Wed, 31 Aug 2022, Robert Richter wrote:

>CXL dports are added in a couple of code paths using
>devm_cxl_add_dport(). Debug messages are individually generated, but
>are incomplete and inconsistent. Change this by moving its generation
>to devm_cxl_add_dport(). This unifies the messages and reduces code
>duplication. Also, generate messages on failure.
>
>Signed-off-by: Robert Richter <rrichter@....com>

Reviewed-by: Davidlohr Bueso <dave@...olabs.net>