linux-kernel - Re: [PATCH] selftests: kvm: Fix a compile error in selftests/kvm/rseq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Sep 2022 17:54:13 +0100
From:   Liam Merwick <liam.merwick@...cle.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Jinrong Liang <ljr.kernel@...il.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Joerg Roedel <joro@...tes.org>,
        Jinrong Liang <cloudliang@...cent.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: kvm: Fix a compile error in
 selftests/kvm/rseq_test.c

On 07/09/2022 17:01, Sean Christopherson wrote:
> On Tue, Aug 02, 2022, Jinrong Liang wrote:
>> From: Jinrong Liang <cloudliang@...cent.com>
>>
>> The following warning appears when executing:
>> 	make -C tools/testing/selftests/kvm
>>
>> rseq_test.c: In function ‘main’:
>> rseq_test.c:237:33: warning: implicit declaration of function ‘gettid’; did you mean ‘getgid’? [-Wimplicit-function-declaration]
>>            (void *)(unsigned long)gettid());
>>                                   ^~~~~~
>>                                   getgid
>> /usr/bin/ld: /tmp/ccr5mMko.o: in function `main':
>> ../kvm/tools/testing/selftests/kvm/rseq_test.c:237: undefined reference to `gettid'
>> collect2: error: ld returned 1 exit status
>> make: *** [../lib.mk:173: ../kvm/tools/testing/selftests/kvm/rseq_test] Error 1
>>
>> Use the more compatible syscall(SYS_gettid) instead of gettid() to fix it.
>> More subsequent reuse may cause it to be wrapped in a lib file.
>>
>> Signed-off-by: Jinrong Liang <cloudliang@...cent.com>
>> ---
> 
> Reviewed-by: Sean Christopherson <seanjc@...gle.com>
> 

Can a 'Cc: stable@...r.kernel.org' be added also as e923b0537d28 got 
backported to v5.15.58

Reviewed-by: Liam Merwick <liam.merwick@...cle.com>


> 
> Paolo, do you want to grab this for 6.0?  It doesn't look like we're going to have
> a more elegant solution anytime soon...