linux-kernel - Re: [PATCH v2] crypto: aspeed: fix format unexpected build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <712da429-6d0d-325f-1c53-39326faa2d41@infradead.org>
Date:   Tue, 6 Sep 2022 20:02:10 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Neal Liu <neal_liu@...eedtech.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        linux-aspeed@...ts.ozlabs.org, linux-crypto@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        BMC-SW@...eedtech.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] crypto: aspeed: fix format unexpected build warning



On 9/6/22 19:13, Herbert Xu wrote:
> On Mon, Sep 05, 2022 at 01:24:49PM +0800, Neal Liu wrote:
>>
>> @@ -324,7 +324,7 @@ static int aspeed_hace_ahash_trigger(struct aspeed_hace_dev *hace_dev,
>>  	struct ahash_request *req = hash_engine->req;
>>  	struct aspeed_sham_reqctx *rctx = ahash_request_ctx(req);
>>  
>> -	AHASH_DBG(hace_dev, "src_dma:0x%x, digest_dma:0x%x, length:0x%x\n",
>> +	AHASH_DBG(hace_dev, "src_dma:%zu, digest_dma:%zu, length:%zu\n",
>>  		  hash_engine->src_dma, hash_engine->digest_dma,
>>  		  hash_engine->src_length);
> 
> Shouldn't we use %pad instead of %zu for dma_addr_t (you'll also
> need to pass in a dma_addr_t pointer instead of the value)?

That sounds correct.
I only looked at the size_t parts...

-- 
~Randy