[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202209080150.2UI2clHd-lkp@intel.com>
Date: Thu, 8 Sep 2022 01:40:48 +0800
From: kernel test robot <lkp@...el.com>
To: luca.ceresoli@...tlin.com, alsa-devel@...a-project.org,
linux-rockchip@...ts.infradead.org
Cc: kbuild-all@...ts.01.org, Luca Ceresoli <luca.ceresoli@...tlin.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Heiko Stuebner <heiko@...ech.de>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Nicolas Frattaroli <frattaroli.nicolas@...il.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Johan Jonker <jbx6244@...il.com>,
Chris Morgan <macromorgan@...mail.com>
Subject: Re: [PATCH 7/8] ASoC: codecs: Add RK3308 internal audio codec driver
Hi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on rockchip/for-next tiwai-sound/for-next linus/master v6.0-rc4 next-20220907]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/luca-ceresoli-bootlin-com/Add-support-for-the-internal-RK3308-audio-codec/20220907-222555
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: powerpc-allmodconfig
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/786c160ad64ae5a6c5266184b12ecf2674db2fbe
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review luca-ceresoli-bootlin-com/Add-support-for-the-internal-RK3308-audio-codec/20220907-222555
git checkout 786c160ad64ae5a6c5266184b12ecf2674db2fbe
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash sound/soc/codecs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
sound/soc/codecs/rk3308_codec.c: In function 'rk3308_codec_parse_dt':
>> sound/soc/codecs/rk3308_codec.c:2007:13: warning: variable 'err' set but not used [-Wunused-but-set-variable]
2007 | int err;
| ^~~
vim +/err +2007 sound/soc/codecs/rk3308_codec.c
2003
2004 static int rk3308_codec_parse_dt(struct rk3308_codec_priv *rk3308)
2005 {
2006 struct device_node *np = rk3308->dev->of_node;
> 2007 int err;
2008
2009 /* Default value is 0 */
2010 err = of_property_read_u32(np, "rockchip,micbias-avdd-multiplier",
2011 &rk3308->micbias_avdd_mult);
2012 if (rk3308->micbias_avdd_mult >= RK3308_CODEC_MICBIAS_NUM)
2013 return dev_err_probe(rk3308->dev, -EINVAL,
2014 "Invalid value for 'rockchip,micbias-avdd-multiplier'\n");
2015
2016 return 0;
2017 }
2018
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (319670 bytes)
Powered by blists - more mailing lists