linux-kernel - Re: [PATCH net-next v5 5/8] net: phylink: Adjust link settings based on rate adaptation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxjdqMjtw8Rr9eKe@shell.armlinux.org.uk>
Date:   Wed, 7 Sep 2022 19:06:32 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Sean Anderson <sean.anderson@...o.com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        linux-kernel@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next v5 5/8] net: phylink: Adjust link settings based
 on rate adaptation

On Wed, Sep 07, 2022 at 01:01:49PM -0400, Sean Anderson wrote:
> > >   	if (pl->pcs && pl->pcs->ops->pcs_link_up)
> > >   		pl->pcs->ops->pcs_link_up(pl->pcs, pl->cur_link_an_mode,
> > > -					 pl->cur_interface,
> > > -					 link_state.speed, link_state.duplex);
> > > +					  pl->cur_interface, speed, duplex);
> > 
> > It seems you have one extra unnecessary space here - not sure how
> > that occurred as it isn't in my original patch.
> > 
> 
> This corrects a spacing issue in the existing code.

Okay, I agree.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!