linux-kernel - [peterz-queue:sched/psi 11/11] kernel/cgroup/cgroup.c:3819:4: error: implicit declaration of function 'cgroup_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 8 Sep 2022 03:32:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chengming Zhou <zhouchengming@...edance.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>
Subject: [peterz-queue:sched/psi 11/11] kernel/cgroup/cgroup.c:3819:4: error:
 implicit declaration of function 'cgroup_file_show' is invalid in C99

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/psi
head:   d79e9c758a62dfe7e3472dbf99400c2774ba51f2
commit: d79e9c758a62dfe7e3472dbf99400c2774ba51f2 [11/11] sched/psi: Per-cgroup PSI accounting disable/re-enable interface
config: x86_64-randconfig-a001 (https://download.01.org/0day-ci/archive/20220908/202209080327.r83nfBI5-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=d79e9c758a62dfe7e3472dbf99400c2774ba51f2
        git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
        git fetch --no-tags peterz-queue sched/psi
        git checkout d79e9c758a62dfe7e3472dbf99400c2774ba51f2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> kernel/cgroup/cgroup.c:3819:4: error: implicit declaration of function 'cgroup_file_show' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                           cgroup_file_show(&cgrp->psi_files[i], enable);
                           ^
   kernel/cgroup/cgroup.c:3819:4: note: did you mean 'cgroup_type_show'?
   kernel/cgroup/cgroup.c:3511:12: note: 'cgroup_type_show' declared here
   static int cgroup_type_show(struct seq_file *seq, void *v)
              ^
   1 error generated.


vim +/cgroup_file_show +3819 kernel/cgroup/cgroup.c

  3792	
  3793	static ssize_t cgroup_pressure_write(struct kernfs_open_file *of,
  3794					     char *buf, size_t nbytes,
  3795					     loff_t off)
  3796	{
  3797		ssize_t ret;
  3798		int enable;
  3799		struct cgroup *cgrp;
  3800		struct psi_group *psi;
  3801	
  3802		ret = kstrtoint(strstrip(buf), 0, &enable);
  3803		if (ret)
  3804			return ret;
  3805	
  3806		if (enable < 0 || enable > 1)
  3807			return -ERANGE;
  3808	
  3809		cgrp = cgroup_kn_lock_live(of->kn, false);
  3810		if (!cgrp)
  3811			return -ENOENT;
  3812	
  3813		psi = cgroup_psi(cgrp);
  3814		if (psi->enabled != enable) {
  3815			int i;
  3816	
  3817			/* show or hide {cpu,memory,io,irq}.pressure files */
  3818			for (i = 0; i < NR_PSI_RESOURCES; i++)
> 3819				cgroup_file_show(&cgrp->psi_files[i], enable);
  3820	
  3821			psi->enabled = enable;
  3822			if (enable)
  3823				psi_cgroup_restart(psi);
  3824		}
  3825	
  3826		cgroup_kn_unlock(of->kn);
  3827	
  3828		return nbytes;
  3829	}
  3830	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp