linux-kernel - Re: [v4 1/5] HID: core: Export hid_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2209072208490.19850@cbobk.fhfr.pm>
Date:   Wed, 7 Sep 2022 22:09:55 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Bastien Nocera <hadess@...ess.net>
cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "Peter F . Patel-Schneider" <pfpschneider@...il.com>,
        Filipe Laíns <lains@...eup.net>,
        Nestor Lopez Casado <nlopezcasad@...itech.com>
Subject: Re: [v4 1/5] HID: core: Export hid_match_id()

On Wed, 7 Sep 2022, Bastien Nocera wrote:

> > Export hid_match_id() so it can be used in device-specific drivers to
> > implement their own matching with open-coding a match function.
> > 
> > Signed-off-by: Bastien Nocera <hadess@...ess.net>
> > ---
> >  drivers/hid/hid-core.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > index b7f5566e338d..72f8d8835b34 100644
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -2088,6 +2088,7 @@ const struct hid_device_id *hid_match_id(const
> > struct hid_device *hdev,
> >  
> >         return NULL;
> >  }
> > +EXPORT_SYMBOL_GPL(hid_match_id);
> >  
> >  static const struct hid_device_id hid_hiddev_list[] = {
> >         { HID_USB_DEVICE(USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS) },
> 
> If those patches look good to you, would be great to get merged.
> Benjamin doesn't have the bandwidth to test the patches on his own test
> hardware right now, but I've been using them daily for a week now.

Alright, I was waiting for Ack from Benjamin, but based on this, and due 
to the fact that I don't see any issue with it myself, I've now applied 
the series to for-6.1/logitech branch so that it gets as much linux-next 
exposure as possible.

Thanks,

-- 
Jiri Kosina
SUSE Labs