linux-kernel - Re: [PATCH v9 25/33] dt-bindings: crypto: rockchip: convert to new driver bindings

Open Source and information security mailing list archives

Message-ID: <20220907203853.GA288174-robh@kernel.org>
Date:   Wed, 7 Sep 2022 15:38:53 -0500
From:   Rob Herring <robh@...nel.org>
To:     Corentin Labbe <clabbe@...libre.com>
Cc:     heiko@...ech.de, herbert@...dor.apana.org.au, ardb@...nel.org,
        davem@...emloft.net, krzysztof.kozlowski+dt@...aro.org,
        mturquette@...libre.com, sboyd@...nel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v9 25/33] dt-bindings: crypto: rockchip: convert to new
 driver bindings

On Thu, Sep 01, 2022 at 12:57:02PM +0000, Corentin Labbe wrote:
> The latest addition to the rockchip crypto driver need to update the
> driver bindings.

This sounds like you changed the driver, so change the binding. That 
would be an ABI break. But it looks like you are adding support for new 
h/w, so say that. Bindings aren't about a driver.

> 
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
>  .../crypto/rockchip,rk3288-crypto.yaml        | 79 +++++++++++++++++--
>  1 file changed, 71 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> index 8a219d439d02..b7870a4cbdbe 100644
> --- a/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> @@ -13,6 +13,8 @@ properties:
>    compatible:
>      enum:
>        - rockchip,rk3288-crypto
> +      - rockchip,rk3328-crypto
> +      - rockchip,rk3399-crypto
>  
>    reg:
>      maxItems: 1
> @@ -21,21 +23,82 @@ properties:
>      maxItems: 1
>  
>    clocks:
> +    minItems: 3
>      maxItems: 4
>  
>    clock-names:
> -    items:
> -      - const: aclk
> -      - const: hclk
> -      - const: sclk
> -      - const: apb_pclk
> +    minItems: 3
> +    maxItems: 4
>  
>    resets:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 3
>  
>    reset-names:
> -    items:
> -      - const: crypto-rst
> +    minItems: 1
> +    maxItems: 3
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: rockchip,rk3288-crypto
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 4
> +        clock-names:
> +          items:
> +            - const: aclk
> +            - const: hclk
> +            - const: sclk
> +            - const: apb_pclk
> +        resets:
> +          maxItems: 1
> +        reset-names:
> +          items:
> +            - const: crypto-rst
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: rockchip,rk3328-crypto
> +    then:
> +      properties:
> +        clocks:
> +          maxItems: 3
> +        clock-names:
> +          items:
> +            - const: hclk_master
> +            - const: hclk_slave
> +            - const: sclk

Do we really need new names? Was 'aclk' not the bus master clock?

If the clocks and resets aren't the same, then maybe these 2 new chips 
should be their own binding.

> +        resets:
> +          maxItems: 1
> +        reset-names:
> +          items:
> +            - const: crypto-rst
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: rockchip,rk3399-crypto
> +    then:
> +      properties:
> +        clocks:
> +          maxItems: 3
> +        clock-names:
> +          items:
> +            - const: hclk_master
> +            - const: hclk_slave
> +            - const: sclk
> +        resets:
> +          minItems: 3
> +        reset-names:
> +          items:
> +            - const: rst_master
> +            - const: rst_slave

'rst_' is redundant, drop.

> +            - const: crypto-rst
>  
>  required:
>    - compatible
> -- 
> 2.35.1
> 
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives