linux-kernel - Re: [Intel-gfx] [PATCH v8 13/16] mei: drop ready bits check after start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94589646-d25c-538f-2513-4775c2c8551e@intel.com>
Date:   Wed, 7 Sep 2022 14:23:43 -0700
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@...el.com>
To:     Tomas Winkler <tomas.winkler@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
CC:     <intel-gfx@...ts.freedesktop.org>,
        Alexander Usyskin <alexander.usyskin@...el.com>,
        <linux-kernel@...r.kernel.org>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Vitaly Lubart <vitaly.lubart@...el.com>
Subject: Re: [Intel-gfx] [PATCH v8 13/16] mei: drop ready bits check after
 start



On 9/7/2022 8:58 AM, Tomas Winkler wrote:
> From: Alexander Usyskin <alexander.usyskin@...el.com>
>
> The check that hardware and host ready bits are set after start
> is redundant and may fail and disable driver if there is
> back-to-back link reset issued right after start.
> This happens during pxp mode transitions when firmware
> undergo reset. Remove these checks to eliminate such failures.
>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@...el.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@...el.com>

Daniele

> ---
>   drivers/misc/mei/init.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c
> index 1b4d5d7870b9..bac8852aad51 100644
> --- a/drivers/misc/mei/init.c
> +++ b/drivers/misc/mei/init.c
> @@ -218,16 +218,6 @@ int mei_start(struct mei_device *dev)
>   		goto err;
>   	}
>   
> -	if (!mei_host_is_ready(dev)) {
> -		dev_err(dev->dev, "host is not ready.\n");
> -		goto err;
> -	}
> -
> -	if (!mei_hw_is_ready(dev)) {
> -		dev_err(dev->dev, "ME is not ready.\n");
> -		goto err;
> -	}
> -
>   	if (!mei_hbm_version_is_supported(dev)) {
>   		dev_dbg(dev->dev, "MEI start failed.\n");
>   		goto err;