linux-kernel - Re: [PATCH next v2 2/2] dt-bindings: i2c: add entry for hisilicon,hisi-i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxkN5Q8iCpRaQq4w@shikoro>
Date:   Wed, 7 Sep 2022 23:32:21 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Yicong Yang <yangyicong@...wei.com>
Cc:     Weilong Chen <chenweilong@...wei.com>, yangyicong@...ilicon.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        xuwei5@...wei.com
Subject: Re: [PATCH next v2 2/2] dt-bindings: i2c: add entry for
 hisilicon,hisi-i2c


> I think it misses some properties here?
> 
> - i2c-sda-hold-time-ns
> - sda_fall_ns
> - scl_rise_ns
> ...
> 
> Do we need to mention them here?

I think so. But for a definitive answer, the devicetree-list should be
on CC for proper review.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)