lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Sep 2022 00:51:10 +0300 From: Tomas Winkler <tomas.winkler@...el.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch> Cc: Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>, intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Tomas Winkler <tomas.winkler@...el.com>, Alexander Usyskin <alexander.usyskin@...el.com>, Vitaly Lubart <vitaly.lubart@...el.com>, Daniele Ceraolo Spurio <daniele.ceraolospurio@...el.com> Subject: [PATCH v9 13/16] mei: drop ready bits check after start From: Alexander Usyskin <alexander.usyskin@...el.com> The check that hardware and host ready bits are set after start is redundant and may fail and disable driver if there is back-to-back link reset issued right after start. This happens during pxp mode transitions when firmware undergo reset. Remove these checks to eliminate such failures. Signed-off-by: Alexander Usyskin <alexander.usyskin@...el.com> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@...el.com> --- V8: New in the series V9: Rebase drivers/misc/mei/init.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c index 1b4d5d7870b9..bac8852aad51 100644 --- a/drivers/misc/mei/init.c +++ b/drivers/misc/mei/init.c @@ -218,16 +218,6 @@ int mei_start(struct mei_device *dev) goto err; } - if (!mei_host_is_ready(dev)) { - dev_err(dev->dev, "host is not ready.\n"); - goto err; - } - - if (!mei_hw_is_ready(dev)) { - dev_err(dev->dev, "ME is not ready.\n"); - goto err; - } - if (!mei_hbm_version_is_supported(dev)) { dev_dbg(dev->dev, "MEI start failed.\n"); goto err; -- 2.37.2
Powered by blists - more mailing lists