linux-kernel - [PATCH] driver: of: overlay: demote message to warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220907230709.271889-1-danielwa@cisco.com>
Date:   Wed,  7 Sep 2022 16:07:08 -0700
From:   Daniel Walker <danielwa@...co.com>
To:     Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
        Frank Rowand <frowand.list@...il.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     xe-linux-external@...co.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] driver: of: overlay: demote message to warning

This warning message shows by default on the vast majority of overlays
applied. Despite the text identifying this as a warning it is marked
with the loglevel for error. At Cisco we filter the loglevels to only
show error messages. We end up seeing this message but it's not really
an error.

For this reason it makes sense to demote the message to the warning
loglevel.

Cc: xe-linux-external@...co.com
Signed-off-by: Daniel Walker <danielwa@...co.com>
---
 drivers/of/overlay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index bd8ff4df723d..4ae276ed9a65 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
 	}
 
 	if (!of_node_check_flag(target->np, OF_OVERLAY))
-		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
+		pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
 		       target->np, new_prop->name);
 
 	if (ret) {
-- 
2.25.1