linux-kernel - [PATCH] PCI: fu740: do not use clock name when requesting clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220907054020.745672-1-uwu@icenowy.me>
Date:   Wed,  7 Sep 2022 13:40:20 +0800
From:   Icenowy Zheng <uwu@...nowy.me>
To:     Paul Walmsley <paul.walmsley@...ive.com>,
        Greentime Hu <greentime.hu@...ive.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org, Icenowy Zheng <uwu@...nowy.me>
Subject: [PATCH] PCI: fu740: do not use clock name when requesting clock

The DT binding of FU740 PCIe does not enforce a clock-names property,
and there exist some device tree that has a clock name that does not
stick to the one used by Linux DT (e.g. the one shipped with current
U-Boot mainline).

Drop the name in the clock request, instead just pass NULL (because
this device should have only a single clock).

Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
---
 drivers/pci/controller/dwc/pcie-fu740.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c
index 0c90583c078b..edb218a37a4f 100644
--- a/drivers/pci/controller/dwc/pcie-fu740.c
+++ b/drivers/pci/controller/dwc/pcie-fu740.c
@@ -315,7 +315,7 @@ static int fu740_pcie_probe(struct platform_device *pdev)
 		return dev_err_probe(dev, PTR_ERR(afp->pwren), "unable to get pwren-gpios\n");
 
 	/* Fetch clocks */
-	afp->pcie_aux = devm_clk_get(dev, "pcie_aux");
+	afp->pcie_aux = devm_clk_get(dev, NULL);
 	if (IS_ERR(afp->pcie_aux))
 		return dev_err_probe(dev, PTR_ERR(afp->pcie_aux),
 					     "pcie_aux clock source missing or invalid\n");
-- 
2.37.1