linux-kernel - Re: [char-misc:char-misc-next 21/24] drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:135:34: sparse: sparse: symbol 'pci1xxxx_gpio_auxiliary_id_table' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yxg1SADGQaJ6jGiY@kroah.com>
Date:   Wed, 7 Sep 2022 08:08:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kumaravel.Thiagarajan@...rochip.com
Cc:     lkp@...el.com, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [char-misc:char-misc-next 21/24]
 drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:135:34: sparse: sparse:
 symbol 'pci1xxxx_gpio_auxiliary_id_table' was not declared. Should it be
 static?

On Tue, Sep 06, 2022 at 06:02:22PM +0000, Kumaravel.Thiagarajan@...rochip.com wrote:
> > -----Original Message-----
> > From: kernel test robot <lkp@...el.com>
> > Sent: Monday, September 5, 2022 12:07 PM
> > To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@...rochip.com>
> > Cc: kbuild-all@...ts.01.org; linux-kernel@...r.kernel.org; Greg Kroah-
> > Hartman <gregkh@...uxfoundation.org>
> > Subject: [char-misc:char-misc-next 21/24]
> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:135:34: sparse: sparse:
> > symbol 'pci1xxxx_gpio_auxiliary_id_table' was not declared. Should it be
> > static?
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > char-misc-next
> > head:   50e177c5bfd9abc3828cb57e14e6169170f6764a
> > commit: 7d3e4d807df2a216b9aa2944372f2b3f6ef3f205 [21/24] misc:
> > microchip: pci1xxxx: load gpio driver for the gpio controller auxiliary device
> > enumerated by the auxiliary bus driver.
> > config: i386-randconfig-s033-20220905
> > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
> .
> .
> .
> > 
> > sparse warnings: (new ones prefixed by >>)
> > >> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:135:34: sparse:
> > sparse: symbol 'pci1xxxx_gpio_auxiliary_id_table' was not declared. Should it
> > be static?
> Greg, do I need to submit another patch to resolve this warning on char-misc-next?
> I did not combine this with the last patch thinking that the last patch would
> be merged with the commit that introduced the errors and not queued.

No, I can't merge it into an older commit as those branches can never be
rebased.

Please send a new fix for this issue as well.

thanks,

greg k-h