linux-kernel - Re: [PATCH v4 02/21] dt-bindings: hwmon: (mr75203) fix "intel, vm-map" property to be optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f638f9bc-b757-c352-7be0-4f9ab6607378@amazon.com>
Date:   Wed, 7 Sep 2022 09:28:20 +0300
From:   "Farber, Eliav" <farbere@...zon.com>
To:     Guenter Roeck <linux@...ck-us.net>
CC:     <jdelvare@...e.com>, <robh+dt@...nel.org>,
        <p.zabel@...gutronix.de>, <rtanwar@...linear.com>,
        <linux-hwmon@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <hhhawa@...zon.com>,
        <jonnyc@...zon.com>, <andriy.shevchenko@...el.com>,
        "Farber, Eliav" <farbere@...zon.com>
Subject: Re: [PATCH v4 02/21] dt-bindings: hwmon: (mr75203) fix "intel,
 vm-map" property to be optional

On 9/6/2022 7:53 PM, Guenter Roeck wrote:
> On Tue, Sep 06, 2022 at 08:33:37AM +0000, Eliav Farber wrote:
>> Change "intel,vm-map" property to be optional instead of required.
>>
>> The driver implementation indicates it is not mandatory to have
>> "intel,vm-map" in the device tree:
>>  - probe doesn't fail in case it is absent.
>>  - explicit comment in code - "Incase intel,vm-map property is not
>>    defined, we assume incremental channel numbers".
>>
>> Fixes: 748022ef093f ("hwmon: Add DT bindings schema for PVT controller")
>> Signed-off-by: Eliav Farber <farbere@...zon.com>
>> ---
>> V3 -> V2:
>> - Change this patch to be first in the series.
>> - Add explanation why "intel,vm-map" is not required.
>>
>
> I don't see how this change warrants dropping Rob's Acked-by tag.
> Am I missing something ? 

My apology. I wasn’t aware I had to keep the Acked-by tag.
I'll add it in v5.

--
Regards, Eliav