linux-kernel - Re: [PATCH v2] mm: use mem_map_offset instead of mem_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220907012633.GA21996@vscode.7~>
Date:   Wed, 7 Sep 2022 01:26:33 +0000
From:   Cheng Li <lic121@...natelecom.cn>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Mike Kravetz <mike.kravetz@...cle.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm: use mem_map_offset instead of mem_map_next

On Tue, Sep 06, 2022 at 05:10:48PM -0700, Andrew Morton wrote:
> On Tue, 6 Sep 2022 10:07:03 -0700 Mike Kravetz <mike.kravetz@...cle.com> wrote:
> 
> > On 09/05/22 06:09, Cheng Li wrote:
> > > To handle discontiguity case, mem_map_next() has a parameter named
> > > `offset`. As a function caller, one would be confused why "get
> > > next entry" needs a parameter named "offset". The other drawback of
> > > mem_map_next() is that the callers must take care of the map between
> > > parameter "iter" and "offset", otherwise we may get an hole or
> > > duplication during iteration. So we use mem_map_offset instead of
> > > mem_map_next.
> > > 
> > > Signed-off-by: Cheng Li <lic121@...natelecom.cn>
> > > Fixes: 69d177c2fc70 ("hugetlbfs: handle pages higher order than MAX_ORDER")
> > 
> > The Fixes tag implies there is a user visible bug.  I do not believe this is
> > the case here.  Is there a user visible bug?
> 
> A Fixes: with a cc:stable would indicate a user-visible bug.  But IMO a
> bare Fixes: is simply a when-to-stop guide to backporters - a
> convenience.  And, I suppose, it has some documentation benefit.
> 
> And if people are really that interested, they can read the dang
> changelog ;)
> 

Thank you for the reviews and the "Fixes" tag tips.

So seems we are agrenment on replacing mem_map_offset() with nth_page().
I may need to send the version 3 :)

I learnt the "Fixes" tag usage from this kenrel contribution guide.[1]

[1]
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes