linux-kernel - Re: [PATCH] remoteproc: report firmware name on load failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3367f73-c2da-3f6d-59a4-209efb114d9e@linaro.org>
Date:   Wed, 7 Sep 2022 10:23:23 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:     Bjorn Andersson <andersson@...nel.org>,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] remoteproc: report firmware name on load failures

On 06/09/2022 21:46, Mathieu Poirier wrote:
> On Wed, Aug 31, 2022 at 07:17:36PM +0300, Krzysztof Kozlowski wrote:
>> remoteproc error messages like:
>>   remoteproc remoteproc0: request_firmware failed: -2
>>   remoteproc remoteproc1: request_firmware failed: -2
>> are difficult to debug as one actually have no clue which device
>> reported it and which firmware is missing.  Be verbose and print the
>> name of the failed firmware.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>  drivers/remoteproc/remoteproc_core.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
>> index e5279ed9a8d7..71cd7ed7a970 100644
>> --- a/drivers/remoteproc/remoteproc_core.c
>> +++ b/drivers/remoteproc/remoteproc_core.c
>> @@ -1923,7 +1923,8 @@ int rproc_trigger_recovery(struct rproc *rproc)
>>  	/* load firmware */
>>  	ret = request_firmware(&firmware_p, rproc->firmware, dev);
>>  	if (ret < 0) {
>> -		dev_err(dev, "request_firmware failed: %d\n", ret);
>> +		dev_err(dev, "request_firmware %s failed: %d\n",
>> +			rproc->firmware, ret);
>>  		goto unlock_mutex;
>>  	}
>>  
>> @@ -2023,7 +2024,8 @@ int rproc_boot(struct rproc *rproc)
>>  		/* load firmware */
>>  		ret = request_firmware(&firmware_p, rproc->firmware, dev);
>>  		if (ret < 0) {
>> -			dev_err(dev, "request_firmware failed: %d\n", ret);
>> +			dev_err(dev, "request_firmware %s failed: %d\n",
>> +				rproc->firmware, ret);
> 
> That information is already available in sysfs 

Hm, it's not in deferred probe reasons, so where can I find it in sysfs?

> but if you are really keen on it
> please do the same for rproc_trigger_auto_boot().
Sure.

Best regards,
Krzysztof