linux-kernel - Re: [PATCH 09/12] dt-bindings: soc: qcom: apr: correct service children

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f91afa5-b5bf-4f26-c540-a04e52825248@linaro.org>
Date:   Wed, 7 Sep 2022 10:30:53 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Mark Brown <broonie@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Liam Girdwood <lgirdwood@...il.com>,
        Andy Gross <agross@...nel.org>, alsa-devel@...a-project.org,
        Rob Herring <robh+dt@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCH 09/12] dt-bindings: soc: qcom: apr: correct service
 children

On 06/09/2022 19:46, Rob Herring wrote:
> On Tue, 06 Sep 2022 14:16:52 +0200, Krzysztof Kozlowski wrote:
>> The APR bindings were not describing properly children nodes for DAIs.
>> None of the DTSes use unit addresses for the children, so correct the
>> nodes and reference their schema: clock-controller, dais and routing.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>  .../bindings/soc/qcom/qcom,apr.yaml           | 38 +++++++++++++------
>>  .../sound/qcom,q6dsp-lpass-clocks.yaml        | 16 ++------
>>  .../sound/qcom,q6dsp-lpass-ports.yaml         | 16 ++------
>>  3 files changed, 35 insertions(+), 35 deletions(-)
>>
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.example.dtb: gpr: service@1: '#address-cells', '#size-cells', 'apm-dai@1' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml

I missed one more place with example to fix.

Best regards,
Krzysztof