linux-kernel - Re: [PATCH -next] mm/hwpoison: add __init/__exit annotations to module init/exit funcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dca9a2ea-1d7d-7a9a-a7d7-6782d589a432@huawei.com>
Date:   Wed, 7 Sep 2022 09:59:46 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Xiu Jianfeng <xiujianfeng@...wei.com>
CC:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        <naoya.horiguchi@....com>, <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] mm/hwpoison: add __init/__exit annotations to
 module init/exit funcs

On 2022/9/6 17:35, Xiu Jianfeng wrote:
> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>

LGTM. Thanks.

Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>

Thanks,
Miaohe Lin

> ---
>  mm/hwpoison-inject.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/hwpoison-inject.c b/mm/hwpoison-inject.c
> index 65e242b5a432..d0548e382b6b 100644
> --- a/mm/hwpoison-inject.c
> +++ b/mm/hwpoison-inject.c
> @@ -63,13 +63,13 @@ static int hwpoison_unpoison(void *data, u64 val)
>  DEFINE_DEBUGFS_ATTRIBUTE(hwpoison_fops, NULL, hwpoison_inject, "%lli\n");
>  DEFINE_DEBUGFS_ATTRIBUTE(unpoison_fops, NULL, hwpoison_unpoison, "%lli\n");
>  
> -static void pfn_inject_exit(void)
> +static void __exit pfn_inject_exit(void)
>  {
>  	hwpoison_filter_enable = 0;
>  	debugfs_remove_recursive(hwpoison_dir);
>  }
>  
> -static int pfn_inject_init(void)
> +static int __init pfn_inject_init(void)
>  {
>  	hwpoison_dir = debugfs_create_dir("hwpoison", NULL);
>  
>