linux-kernel - Re: [PATCH v5 1/6] tracing: Allow multiple hitcount values in histograms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220906220346.53a9a623@gandalf.local.home>
Date:   Tue, 6 Sep 2022 22:03:46 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc:     Tom Zanussi <zanussi@...nel.org>, Ingo Molnar <mingo@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/6] tracing: Allow multiple hitcount values in
 histograms

On Sun,  4 Sep 2022 13:12:20 +0900
"Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:

> From: Tom Zanussi <zanussi@...nel.org>
> 
> The hitcount is treated specially in the histograms - since it's
> always expected to be there regardless of whether the user specified
> anything or not, it's always added as the first histogram value.
> 
> Currently the code doesn't allow it to be added more than once as a
> value, which is inconsistent with all the other possible values.  It
> would seem to be a pointless thing to want to do, but other features
> being added such as percent and graph modifiers don't work properly
> with the current hitcount restrictions.
> 
> Fix this by allowing multiple hitcounts to be added.
> 
> Signed-off-by: Tom Zanussi <zanussi@...nel.org>

Hi Masami,

When posting patches from other people, you still need to add your
Signed-off-by, as that denotes the people who processed the patch before it
made it into git.

-- Steve