linux-kernel - Re: [PATCH] scsi/3w-9xxx: Avoid disabling device if failing to enable it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1v8pzgbym.fsf@ca-mkp.ca.oracle.com>
Date:   Tue, 06 Sep 2022 22:22:49 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Letu Ren <fantasquex@...il.com>
Cc:     aradford@...il.com, jejb@...ux.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zheyu Ma <zheyuma97@...il.com>
Subject: Re: [PATCH] scsi/3w-9xxx: Avoid disabling device if failing to
 enable it


Letu,

> The original code will goto out_disable_device and
> `pci_disable_device` if `pci_enable_device` fails. Kernel will
> generate a warning message "3w-9xxx 0000:00:05.0: disabling
> already-disabled device". We shouldn't disable a failed to enable
> device. A simple return is fine.

Applied to 6.1/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering